-
-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Slim4] Add ref support to Data Mocker #4932
[Slim4] Add ref support to Data Mocker #4932
Conversation
Don't know what to do with these uncommitted changes: diff --git a/samples/server/petstore/php-slim4/lib/Model/EnumClass.php b/samples/server/petstore/php-slim4/lib/Model/EnumClass.php
index 3ddd829b31..c3998d8602 100644
--- a/samples/server/petstore/php-slim4/lib/Model/EnumClass.php
+++ b/samples/server/petstore/php-slim4/lib/Model/EnumClass.php
@@ -30,8 +30,8 @@ class EnumClass implements ModelInterface
private const MODEL_SCHEMA = <<<'SCHEMA'
{
"type" : "string",
- "default" : "-efg",
- "enum" : [ "_abc", "-efg", "(xyz)" ]
+ "enum" : [ "_abc", "-efg", "(xyz)" ],
+ "default" : "-efg"
}
SCHEMA; I've rebased on latest master, made |
As it turnes out to generate coverage report for a whole project I need to run all test suites at once.
b0c240e
to
8fa10fd
Compare
CI failure not related to this PR except the sample update, which I will take care of after merging this PR into master. |
I'm able to repeat the issue but don't know what went wrong. I've commented out php slim 4 in the ensure-up-to-date script for the time being. |
* master: (187 commits) [core] Initial FeatureSet structures and definitions (OpenAPITools#3614) Add Cisco to the user list (OpenAPITools#4971) comment out php slim4 in ensure-up-to-date update samples [Python] Allow models to have properties of type self (OpenAPITools#4888) Add npmRepository option to javascript generators (OpenAPITools#4956) [Slim4] Add ref support to Data Mocker (OpenAPITools#4932) Fix auto-labeler for jax-rs (OpenAPITools#4943) [doc] full generator details (OpenAPITools#4941) comment out python flask 2 test (OpenAPITools#4949) [jaxrs-spec][quarkus] update to version 1.1.1.Final (OpenAPITools#4935) [cli] Full config help details (OpenAPITools#4928) Add RequestFile to typescript-node model template (OpenAPITools#4903) [csharp] enum suffix changes enumValueNameSuffix to enumValueSuffix (OpenAPITools#4927) [C#] allow customization of generated enum suffixes (OpenAPITools#4301) [Kotlin] Correct isInherited flag for Kotlin generators (OpenAPITools#4254) [Rust Server] Fix panic handling headers (OpenAPITools#4877) Initial CODEOWNERS (OpenAPITools#4924) [scala] Support for Set when array has uniqueItems=true (OpenAPITools#4926) remove nodejs server samples, scripts (OpenAPITools#4919) ...
PR checklist
./bin/
(or Windows batch scripts under.\bin\windows
) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run./bin/{LANG}-petstore.sh
,./bin/openapi3/{LANG}-petstore.sh
if updating the code or mustache templates for a language ({LANG}
) (e.g. php, ruby, python, etc).master
,4.3.x
,5.0.x
. Default:master
.Current progress
Now
OpenApiDataMocker
supports refs in arrayitems
key and objectproperties
. When mocker cannot find referenced model it throwsInvalidArgumentException
.output:
TODO
Method
mockFromRef
should return model class instance(eg.new Animal()
) notStdClass
. As soon as Slim4 server has poor models implementation right now I will change it in future.Related to #3545
cc @jebentier, @dkarlovi, @mandrean, @jfastnacht, @ackintosh, @renepardon