Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core] Add warning on GET request with body #4413

Closed
wants to merge 3 commits into from

Conversation

ybelenko
Copy link
Contributor

@ybelenko ybelenko commented Nov 7, 2019

PR checklist

  • Read the contribution guidelines.
  • If contributing template-only or documentation-only changes which will change sample output, build the project before.
  • Run the shell script(s) under ./bin/ (or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).
  • File the PR against the correct branch: master, 4.3.x, 5.0.x. Default: master.
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

Closes #4216

Warning looks like:

[main] WARN  o.o.codegen.DefaultCodegen - DELETE operation 'deleteOrder' contains body 
parameter. Please, make sure your framework handles DELETE method with body properly.
[main] WARN  o.o.codegen.DefaultCodegen - GET operation 'testEnumParameters' contains 
form parameter. Please, make sure your framework handles GET method with form properly.

cc @OpenAPITools/generator-core-team

@wing328
Copy link
Member

wing328 commented Nov 8, 2019

Thanks for the PR. Similar feedback as #4412 (comment)

@jimschubert
Copy link
Member

Included in #4979

@jimschubert jimschubert closed this Feb 2, 2020
@ybelenko ybelenko deleted the get-with-body branch February 2, 2020 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[REQ] Add warning on GET request with body
3 participants