Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C] Update build-and-test.bash for CI errors #4312

Merged
merged 3 commits into from
Oct 30, 2019

Conversation

zhemant
Copy link
Contributor

@zhemant zhemant commented Oct 29, 2019

PR checklist

  • Read the contribution guidelines.
  • If contributing template-only or documentation-only changes which will change sample output, build the project before.
  • Run the shell script(s) under ./bin/ (or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).
  • File the PR against the correct branch: master, 4.1.x, 5.0.x. Default: master.
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

@wing328

add check for non autogenerated test file
Add instructions on how to test petstore sample manual tests.
@auto-labeler
Copy link

auto-labeler bot commented Oct 29, 2019

👍 Thanks for opening this issue!
🏷 I have applied any labels matching special text in your issue.

The team will review the labels and make any necessary changes.

@zhemant zhemant mentioned this pull request Oct 29, 2019
1 task
@wing328
Copy link
Member

wing328 commented Oct 30, 2019

CircleCI failure not related to this PR.

@wing328 wing328 merged commit 6795434 into OpenAPITools:master Oct 30, 2019
@wing328 wing328 added this to the 4.2.0 milestone Oct 30, 2019
michelealbano added a commit to michelealbano/openapi-generator that referenced this pull request Oct 30, 2019
…ano/openapi-generator into CadditionalProperties

Merged with new generated test files, after improvements of Pull Request OpenAPITools#4312.

Removed anything not related to C additional properties.
@wing328
Copy link
Member

wing328 commented Oct 31, 2019

@zhemant thanks for the PR, which has been included in v4.2.0 release: https://twitter.com/oas_generator/status/1189824932345069569

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants