Update to jackson-datatype-threetenbp 2.9.10 #4176
Conversation
|
@wing328 Maybe you could be so nice to tag the relevant maintainers. |
|
cc
|
There was a problem hiding this comment.
LGTM. Thanks for knocking this out!
We should definitely be on Jackson 2.9.10.
However, I'm not personally familiar with the threeten artifact or whether upgrading might have an effect on clients. This seems like a simple enough fix, but I'll defer to another collaborator who is familiar with threeten to identify whether or not this might be a breaking client change before merging to master.
|
No expert in threeten either but the version upgrade looks reasonable to me |
|
@joschi thanks for the PR, which has been included in v4.2.0 release: https://twitter.com/oas_generator/status/1189824932345069569 |
Update the Jackson datatype support for ThreeTen to the latest version working with Jackson 2.9.10.
This way, there should be only minimal differences between the generated code when when using ThreeTen backport vs. not using ThreeTen backport.
swagger-api/swagger-codegen-generators#489
swagger-api/swagger-codegen#9748
PR checklist
./bin/(or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run./bin/{LANG}-petstore.sh,./bin/openapi3/{LANG}-petstore.shif updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).master,4.1.x,5.0.x. Default:master.