[typescript-inversify] Fix multipart form uploads #4131
Conversation
|
👍 Thanks for opening this issue! The team will review the labels and make any necessary changes. |
| @@ -152,7 +152,12 @@ export class {{classname}} { | |||
|
|
|||
| {{#hasFormParams}} | |||
| let formData: FormData = new FormData(); | |||
| {{#isMultipart}} | |||
| headers['Content-Type'] = 'multipart/form-data'; | |||
There was a problem hiding this comment.
It should‘t be set explicitly, as there would be a problem with the separator, or am I missing something?
There was a problem hiding this comment.
Yes that’s technically correct, it shouldn’t be explicitly set. But because of the way the HttpClient does an Object.assign to get some default headers, if you leave content-type undefined it becomes application/json which is still wrong
So alongside setting this content-type, I added a check to HttpClient to see if it is a multipart upload and do a delete headers[“content-type”]
There was a problem hiding this comment.
modules/openapi-generator/src/main/resources/typescript-inversify/HttpClient.mustache
Outdated
Show resolved
Hide resolved
…ify/HttpClient.mustache Co-Authored-By: Esteban Gehring <[email protected]>
|
@siada can you please re-generate the samples and merge the latest master? |
|
@siada thanks for the PR, which has been included in v4.2.0 release: https://twitter.com/oas_generator/status/1189824932345069569 |
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.sh,./bin/openapi3/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\. If contributing template-only or documentation-only changes which will change sample output, be sure to build the project first.master,4.1.x,5.0.x. Default:master.Description of the PR
This PR fixes an issue with the typescript-inversify generator for multipart file uploads.
When trying to use this generator within my own code I found that for file uploads, it was adding a content-type header of
application/x-www-form-urlencoded;charset=UTF-8which was incorrectBased on my own testing I found that when doing a multipart upload using fetch(), the content-type header should be left unset as the browser will itself handle adding the multipart boundary fields
This PR also fixes #4129 as the 'body' param isn't set for www-form or mutlipart requests
@TiFu (2017/07) @taxpon (2017/07) @sebastianhaas (2017/07) @kenisteward (2017/07) @Vrolijkx (2017/09) @macjohnny (2018/01) @nicokoenig (2018/09) @topce (2018/10) @akehir (2019/07)