Sanitizes model names so they're valid class/interface names #4127
Conversation
| int count = 0; | ||
| boolean done = false; | ||
| key = key.replaceAll("/", "_"); // e.g. /me/videos => _me_videos | ||
| key = key.replaceAll("[^a-z_\\.A-Z0-9 ]", ""); // FIXME: a parameter |
There was a problem hiding this comment.
I couldn't make sense of why \ and . was allowed, so I removed them.
If anyone got some input on it I'm listening 👂
There was a problem hiding this comment.
No idea either. git blame doesn't reveal useful information. It may be a bug that's present a while ago.
|
cc @OpenAPITools/generator-core-team |
|
Hmm think I messed up. Isn't this the code that generate backend stuff and not frontend stuff? |
|
the code is responsible for creating the abstract model used by e.g. the frontend generators, so I think this should also apply for the frontend clients. |
Can someone trigger a rebuild |
I re-started the CircleCI build |
|
CircleCI issue has been addressed. |
wing328
changed the title
wing328
changed the title
|
@snebjorn thanks for the PR, which has been included in v4.2.0 release: https://twitter.com/oas_generator/status/1189824932345069569 |
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.sh,./bin/openapi3/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\. If contributing template-only or documentation-only changes which will change sample output, be sure to build the project first.master,4.1.x,5.0.x. Default:master.Description of the PR
fixes #4097
though the issue was about Angular the issue is a core issue