typescript-fetch: fix empty URLSearchParams request body #4103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkrtmy
commented
Oct 9, 2019
| @@ -49,7 +49,7 @@ export class BaseAPI { | |||
| // do not handle correctly sometimes. | |||
| url += '?' + this.configuration.queryParamsStringify(context.query); | |||
| } | |||
| const body = (context.body instanceof FormData || isBlob(context.body)) | |||
| const body = (context.body instanceof FormData || context.body instanceof URLSearchParams || isBlob(context.body)) | |||
| ? context.body | |||
| : JSON.stringify(context.body); | |||
There was a problem hiding this comment.
URLSearchParams has fallen this line
> console.log(JSON.stringify(new URLSearchParams('hoge=fuga&piyo=piyopiyo')));
{}
|
CI failed... It works well at local... |
|
sounds reasonable |
|
@tkrtmy thanks for the PR, which has been included in v4.2.0 release: https://twitter.com/oas_generator/status/1189824932345069569 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.sh,./bin/openapi3/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\. If contributing template-only or documentation-only changes which will change sample output, be sure to build the project first.master,4.1.x,5.0.x. Default:master.Description of the PR
This pull-request is correction patch for #3934 . (related to #3920 )
URLSearchParams body is converted empty JSON Object by
JSON.stringifysince missing check.Technical Committee
@TiFu (2017/07) @taxpon (2017/07) @sebastianhaas (2017/07) @kenisteward (2017/07) @Vrolijkx (2017/09) @macjohnny (2018/01) @nicokoenig (2018/09) @topce (2018/10) @akehir (2019/07)