Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused property (SecuritySchemeDefinition) #4081

Merged
merged 1 commit into from
Oct 7, 2019

Conversation

Zomzog
Copy link
Contributor

@Zomzog Zomzog commented Oct 6, 2019

Fix #4066

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\. If contributing template-only or documentation-only changes which will change sample output, be sure to build the project first.
  • Filed the PR against the correct branch: master, 4.1.x, 5.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

The field SecuritySchemeDefinition auth is deprecated and no more used in the generator.

I think we can just remove it.

@wing328
@jimschubert
@cbornet
@ackintosh
@jmini
@etherealjoy

@wing328 wing328 added this to the 4.2.0 milestone Oct 7, 2019
@wing328 wing328 merged commit c5e0ecf into OpenAPITools:master Oct 7, 2019
@wing328 wing328 changed the title Remove unused property Remove unused property (SecuritySchemeDefinition) Oct 7, 2019
@wing328
Copy link
Member

wing328 commented Oct 31, 2019

@Zomzog thanks for the PR, which has been included in v4.2.0 release: https://twitter.com/oas_generator/status/1189824932345069569

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] POST endpoint playgrounds on http://api.openapi-generator.tech are broken
2 participants