Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DELETE with body to kotlin client #4047

Merged
merged 4 commits into from
Oct 8, 2019
Merged

Add DELETE with body to kotlin client #4047

merged 4 commits into from
Oct 8, 2019

Conversation

oharaandrew314
Copy link
Contributor

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\. If contributing template-only or documentation-only changes which will change sample output, be sure to build the project first.
  • Filed the PR against the correct branch: master, 4.1.x, 5.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

@jimschubert @dr4ke616 @karismann @Zomzog

Description of the PR

Closes #4046

@wing328
Copy link
Member

wing328 commented Oct 7, 2019

Thanks for the PR but your commit (as shown in the Commits tab) is not linked to your Github account, which means this PR won't count as your contribution in https://github.com/OpenAPITools/openapi-generator/graphs/contributors.

Let me know if you need help fixing it.

Ref: https://github.com/OpenAPITools/openapi-generator/wiki/FAQ#how-can-i-update-commits-that-are-not-linked-to-my-github-account

@oharaandrew314
Copy link
Contributor Author

@wing328 Thanks, I added the email to my account. Now the commits are recognized as me.

I updated the sample that circle CI complained about. Hopefully we're good to go after that.

@oharaandrew314
Copy link
Contributor Author

It would appear that all recent travis builds are failing. Seems to be a broken dependency for valgrind.

@oharaandrew314
Copy link
Contributor Author

Re-opening to re-run builds. Seems like travis might be fixed now.

@wing328
Copy link
Member

wing328 commented Oct 8, 2019

The travis issue has been fixed in the master so don't worry about it.

@wing328 wing328 merged commit 682af7c into OpenAPITools:master Oct 8, 2019
@wing328
Copy link
Member

wing328 commented Oct 31, 2019

@oharaandrew314 thanks for the PR, which has been included in v4.2.0 release: https://twitter.com/oas_generator/status/1189824932345069569

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[REQ] Kotlin Client should support DELETE with body
2 participants