Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CSharp] add optional flag "optionalEmitDefaultValues" and update template #4010

Merged
merged 1 commit into from
Oct 9, 2019
Merged

Conversation

sdoeringNew
Copy link
Contributor

@sdoeringNew sdoeringNew commented Oct 1, 2019

PR checklist

  • Read the contribution guidelines. But I'm unsure if I named the vendorExtension flag correctly. I do not put the csharp prefix as the other extensions in CSharp did not have this prefix, too.
  • Ran the shell script under ./bin/ to update Petstore sample for CSharp... But I haven't committed them because there were many other changes from previous template changes - so nobody seem to commit them. At least I saw that the flag worked as expected.
  • Filed the PR against the correct branch: master
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.
  • Waited for the checks to have passed.

Description of the PR

This commit addresses issue #3274 and adds the proposed optionalEmitDefaultValues flag.

Invite cool reviewers

@mandrean (2017/08), @jimschubert (2017/09)

…plate

This commit addresses issue #3274 and adds the proposed optionalEmitDefaultValues flag.
@wing328
Copy link
Member

wing328 commented Oct 9, 2019

@sdoeringNew thanks for the PR. We can go with this approach to see if users have feedback on this.

@wing328
Copy link
Member

wing328 commented Oct 9, 2019

I would recommend creating a new branch as per git best practic for your upcoming PRs.

@wing328 wing328 merged commit d8c3b4d into OpenAPITools:master Oct 9, 2019
@wing328 wing328 added this to the 4.2.0 milestone Oct 9, 2019
@wing328
Copy link
Member

wing328 commented Oct 31, 2019

@sdoeringNew thanks for the PR, which has been included in v4.2.0 release: https://twitter.com/oas_generator/status/1189824932345069569

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants