Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[golang] Regenerate all go samples #3988

Merged
merged 3 commits into from
Sep 30, 2019
Merged

[golang] Regenerate all go samples #3988

merged 3 commits into from
Sep 30, 2019

Conversation

etherealjoy
Copy link
Contributor

@etherealjoy etherealjoy commented Sep 29, 2019 •
edited
Loading

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\. If contributing template-only or documentation-only changes which will change sample output, be sure to build the project first.
  • Filed the PR against the correct branch: master, 4.1.x, 5.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

Related to #3975

Running these still produce diffs

./bin/go-experimental-petstore.sh  && ./bin/go-gin-petstore-server.sh \
 && ./bin/go-petstore-server.sh && ./bin/go-petstore.sh && ./bin/go-petstore-withxml.sh
./bin/openapi3/go-experimental-petstore.sh && ./bin/openapi3/go-gin-petstore-server.sh \
&& ./bin/openapi3/go-petstore-server.sh && ./bin/openapi3/go-petstore.sh

cc @OpenAPITools/generator-core-team

@etherealjoy etherealjoy changed the title Regenerate all go samples [golang] Regenerate all go samples Sep 29, 2019
@wing328
Copy link
Member

wing328 commented Sep 29, 2019

@etherealjoy thanks for the PR. I've thought about adding Go experimental client to the ensure-up-to-date script but not sure if it's a good idea.

Given that the outdated samples may cause confusion, let's add these scripts (that you just ran in this PR) to ./bin/utils/ensure-up-to-date.sh so that the CI will ensure these samples are up-to-date.

@etherealjoy
Copy link
Contributor Author

@wing328
There is a mismatch with the signature due to the apikeys holding a map.
But I ran the test locally after updating the test case and they are all good now.
Just some outdated test case that is all.

@etherealjoy
Copy link
Contributor Author

Given that the outdated samples may cause confusion, let's add these scripts (that you just ran in this PR) to ./bin/utils/ensure-up-to-date.sh so that the CI will ensure these samples are up-to-date.

I will update the PR to add these to the script.

@etherealjoy
Copy link
Contributor Author

@wing328
Should I add the up until not checked in files for go-experimental in the openapi3 samples as well?

@etherealjoy etherealjoy merged commit 600a81f into OpenAPITools:master Sep 30, 2019
@shaxbee shaxbee mentioned this pull request Sep 30, 2019
Merged
4 tasks
@etherealjoy etherealjoy added this to the 4.1.3 milestone Sep 30, 2019
Jesse0Michael pushed a commit to Jesse0Michael/openapi-generator that referenced this pull request Oct 3, 2019
@etherealjoy
[golang] Regenerate all go samples (OpenAPITools#3988)
fca22b7 
* Regenerate all go samples

* Update API Key usage

* Add go-experimental script
jimschubert added a commit that referenced this pull request Oct 4, 2019
@jimschubert
Merge branch 'master' into batch-generation
92d7b9f 
* master: (110 commits)
  [golang] Regenerate all go samples  (#3988)
  Better tests for string (number) (#3953)
  Add missing enum processing in C++ codegen, already present for Qt5 (#3986)
  [C++] [Pistache] Removed deprecated warnings (#3985)
  [C++][Pistache] Simplified model template (#3417)
  add go oas3 petstore to ensure up-to-date (#3979)
  replace gitter with slack in the doc (#3977)
  Fix wrong variable name in LessThan and LessThanOrEqual asserts (#3971)
  #3957 - Removed hardcoded baseUrl (#3964)
  Regenerate go openapi3 samples (#3975)
  [rust] Make it easier to test rust client generator (#3543)
  Fix issue3635 (#3948)
  add gradle repository (#3867)
  [java] allow to use setArtifactVersion() programmatically (#3907)
  Add a link to DevRelCon SF 2019 (#3961)
  Add a link to a medium blog post (#3960)
  update maven-compiler-plugin version (#3956)
  fix generateAliasAsModels in default generator (#3951)
  Implement BigDecimal to Decimal in swift4 for currency data as type=string format=number (#3910)
  Add F# Functions server generator (#3933)
  ...
@etherealjoy etherealjoy deleted the regen_go_samples branch October 11, 2019 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Client: Go Enhancement: CI/Test Server: Go
Projects
None yet
Milestone
4.1.3
Development

Successfully merging this pull request may close these issues.
2 participants
@etherealjoy @wing328