Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JavaScript] Remove default parameters syntax, as it's an ES6 feature #2848

Merged
merged 2 commits into from
Jun 3, 2019

Conversation

f-f
Copy link
Contributor

@f-f f-f commented May 9, 2019

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\. If contributing template-only or documentation-only changes which will change sample output, be sure to build the project first.
  • Filed the PR against the correct branch: master, 3.4.x, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

This removes some syntax for "default parameters" from the JavaScript client. The reason is that it's a ES6 feature that doesn't work on IE11

cc @CodeNinjai @frol @cliffano

@wing328 wing328 merged commit b512174 into OpenAPITools:master Jun 3, 2019
@f-f f-f deleted the fix-js-client-default-params branch June 3, 2019 07:40
@f-f
Copy link
Contributor Author

f-f commented Jun 3, 2019

@wing328 thank you!

@wing328
Copy link
Member

wing328 commented Jun 20, 2019

Thanks again for the PR, which has been included in the v4.0.2 release: https://twitter.com/oas_generator/status/1141610197766426626

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants