Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send "true" or "false" for boolean params. #2257

Merged
merged 2 commits into from
Apr 4, 2019

Conversation

jacobweber
Copy link
Contributor

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh, ./bin/security/{LANG}-petstore.sh and ./bin/openapi3/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master, 3.4.x, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language. @jebentier (2017/07), @dkarlovi (2017/07), @mandrean (2017/08), @jfastnacht (2017/09), @ackintosh (2017/09) ❤️, @ybelenko (2018/07), @renepardon (2018/12)

Description of the PR

If you pass a PHP boolean value as a parameter in the query/path/form, this will serialize it as "true" or "false" instead of "1" or "".

Fixes #2204.

@wing328
Copy link
Member

wing328 commented Feb 28, 2019

@jacobweber thanks for the fix, which looks good to me 👍

@wing328 wing328 merged commit b5ede4b into OpenAPITools:master Apr 4, 2019
@wing328 wing328 added this to the 4.0.0 milestone Apr 4, 2019
@etremblay
Copy link
Contributor

Hi, this pr fixes boolean value encoding in ObjectSerializer::toString(), but in current master, this function is not used to encode query string parameters.

I think encoding query parameters was the whole purpose of #2204

Would you like me to open a proper pull request?

@etremblay
Copy link
Contributor

After some investigations, I found that the lost of this fix is a regression from

#3984

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] PHP sends boolean params as "1" or "" instead of "true" or "false"
4 participants