Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[java][Microprofile] add config options to disable usage of ApiExceptionMapper #20762

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

JacobOJ
Copy link

@JacobOJ JacobOJ commented Feb 28, 2025

This PR fixes issue #20751 made by @Munken

It is made configurable whether generated Microprofile API clients should RegisterProvider ApiExceptionMapper.
It is also made configurable whether ApiExceptionMapper should be annotated with @Provider, making it a global exception mapper.

Both properties default to true in order to make this a non-breaking change.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@bbdouglas @sreeshas @jfiala @lukoyanov @cbornet @jeff9finger @karismann @Zomzog @lwlee2608 @martin-mfg

@JacobOJ
Copy link
Author

JacobOJ commented Feb 28, 2025

I see that CircleCI is failing. I'm not sure what the error is or how to fix it

@wing328
Copy link
Member

wing328 commented Mar 2, 2025

Thanks for the PR but your commit (as shown in the Commits tab) is not linked to your Github account, which means this PR won't count as your contribution in https://github.com/OpenAPITools/openapi-generator/graphs/contributors.

Let me know if you need help fixing it.

Ref: https://github.com/OpenAPITools/openapi-generator/wiki/FAQ#how-can-i-update-commits-that-are-not-linked-to-my-github-account

@wing328
Copy link
Member

wing328 commented Mar 2, 2025

for the circleci failure, please ignore it for the time being

@wing328
Copy link
Member

wing328 commented Mar 3, 2025

looks like a rebase went wrong as the PR contains commits from others.

please submit a new one by cherry-picking commits authored by you.

@JacobOJ
Copy link
Author

JacobOJ commented Mar 3, 2025

looks like a rebase went wrong as the PR contains commits from others.

please submit a new one by cherry-picking commits authored by you.

On it :)

@JacobOJ
Copy link
Author

JacobOJ commented Mar 3, 2025

looks like a rebase went wrong as the PR contains commits from others.

please submit a new one by cherry-picking commits authored by you.

It looks to be fixed now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants