Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JavaSpring, kotlin-spring] attach sources when maven and interfaceOnly=true is used #20640

Merged
merged 2 commits into from
Feb 12, 2025

Conversation

zaenk
Copy link
Contributor

@zaenk zaenk commented Feb 11, 2025

When using interfaceOnly, the configuration effectively generates only API interfaces and DTOs. The generated sources can be packaged up and published to a maven repository to be used as an "SDK" for both client and server development.

For these generated libraries, when the developer navigates to definitions, the decomplied code is not easily readable, especially true in case of decompiled kotlin files.

Closes #15659

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

JavaSpring @cachescrubber (2022/02) @welshm (2022/02) @MelleD (2022/02) @atextor (2022/02) @manedev79 (2022/02) @javisst (2022/02) @borsch (2022/02) @banlevente (2022/02) @Zomzog (2022/09) @martin-mfg (2023/08)

kotlin-spring @dr4ke616 (2018/08) @karismann (2019/03) @Zomzog (2019/04) @andrewemery (2019/10) @4brunu (2019/11) @yutaka0m (2020/03) @stefankoppier (2022/06) @e5l (2024/10)

@zaenk zaenk changed the title [JavaSpring, kotlin-spring] attahc sources when maven and interfaceOnly=true is used [JavaSpring, kotlin-spring] attach sources when maven and interfaceOnly=true is used Feb 11, 2025
@wing328 wing328 added this to the 7.12.0 milestone Feb 12, 2025
@wing328
Copy link
Member

wing328 commented Feb 12, 2025

circleci failure not related to this PR

@wing328
Copy link
Member

wing328 commented Feb 12, 2025

thanks for the PR

let's give it a try

@wing328 wing328 merged commit 3eddc9a into OpenAPITools:master Feb 12, 2025
91 of 92 checks passed
@wing328
Copy link
Member

wing328 commented Feb 12, 2025

FYI. Just merged #20647 to improve the mustache template to avoid blank lines.

@zaenk
Copy link
Contributor Author

zaenk commented Feb 12, 2025

this was super fast! thank you! 🙏

@zaenk zaenk deleted the feat/15659-attach-sources branch February 12, 2025 14:06
kgeilmann pushed a commit to kgeilmann/openapi-generator that referenced this pull request Feb 14, 2025
…ly=true is used (OpenAPITools#20640)

* [JavaSpring] attach sources when using maven and interfaceOnly=true

Closes OpenAPITools#15659

* [kotlin-spring] attach sources when using maven and interfaceOnly=true

Closes OpenAPITools#15659
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[REQ] [kotlin-spirng, java-spring] Attach sources to library style outputs (when interfaceOnly=true)
2 participants