Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DefaultCodegen] simplified comparison for required flag #20602

Merged
merged 1 commit into from
Feb 9, 2025

Conversation

balassit
Copy link
Contributor

@balassit balassit commented Feb 6, 2025

SortModelPropertiesByRequiredFlag - simplified comparison to order boolean false first

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@balassit balassit marked this pull request as ready for review February 6, 2025 03:23
@wing328
Copy link
Member

wing328 commented Feb 6, 2025

thanks for the PR

cc @OpenAPITools/generator-core-team

@wing328 wing328 added Feature: Generator Enhancement: Code Cleanup General refactoring, removal of deprecated things, commenting, etc. labels Feb 6, 2025
@wing328 wing328 added this to the 7.12.0 milestone Feb 6, 2025
@wing328 wing328 merged commit 055605b into OpenAPITools:master Feb 9, 2025
15 checks passed
@balassit balassit deleted the bllassit/compare branch February 11, 2025 05:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement: Code Cleanup General refactoring, removal of deprecated things, commenting, etc. Feature: Generator
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants