[WIP] Fix allOf in inline model resolver #1841
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wing328
added
Feature: Generator
Feature: OAS 3.0 spec support
Issue: Bug
WIP
wing328
changed the title
This was referenced Jan 8, 2019
jimschubert
approved these changes
Mar 25, 2019
| Schema m = (Schema) model; | ||
| Map<String, Schema> properties = m.getProperties(); | ||
| flattenProperties(properties, modelName); | ||
| //fixStringModel(m); |
|
|
||
| for (Schema component : schemaList) { | ||
| if (component.get$ref() == null) { | ||
| flattenProperties(component.getProperties(), resolveModelName(component.getTitle(), "composed_" + modelName)); |
There was a problem hiding this comment.
Is there any plan to make component_ configurable here?
|
Not ready to be merged. Will open a new one if needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.shand./bin/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\.master,. Default:3.4.x,4.0.xmaster.Description of the PR
Found this bug while working on better allOf, anyOf, oneOf support:
model instanceof Schemashould be the last check, otherwise all other checks (eg.. ArraySchema) will be skipped.Also deprecating
fixStringModelas we shouldn't need it to remove double quote in enum example valuecc @OpenAPITools/generator-core-team