[C] Support for authentication methods #1628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please have a look, @wing328 @PowerOfCreation |
wing328
reviewed
Dec 10, 2018
| return apiClient; | ||
| } | ||
|
|
||
| void apiClient_free(apiClient_t *apiClient) { | ||
| if(apiClient->dataReceived) { | ||
| free(apiClient->dataReceived); | ||
| } | ||
| free(apiClient); | ||
| //free(apiClient); |
There was a problem hiding this comment.
@zhemant maybe simply remove this line instead of commenting it out?
There was a problem hiding this comment.
I modified the code in new commits, now in API I free the dataReceived and leave apiClient object as it is for the user to free. So If someone doesn't want to reuse apiClient, instead of calling free function for multiple parameters, only 1 function will do it.
wing328
added
Client: C
Enhancement: General
Enhancement: Feature
Feature: Authentication
and removed
Enhancement: General
labels
|
@wing328 Any more modifications are required in this PR? |
|
Not from me. Just restarted the CI job. Let's see how it goes. |
jimschubert
added a commit
to jimschubert/openapi-generator
that referenced
this pull request
Jan 9, 2019
* master: (52 commits) Support for "x-enum-descriptions" (OpenAPITools#1752) add new sample files Add a checklist to issue report (OpenAPITools#1851) Fix typo in template (OpenAPITools#1859) update samples add isModel to updatebooleanflagwithcodegenproperty (OpenAPITools#1844) [python-client] Add model default values (OpenAPITools#1776) fix: force to decode as utf-8 when header contains application/json to avoid text garbling. (OpenAPITools#1700) Better support for composed schema (allOf) (OpenAPITools#1842) Add additional properties to Java CodegenModel (OpenAPITools#1854) Minor Angular type improvements (OpenAPITools#1843) [DART] fix: set fields to null if json value is null. (OpenAPITools#1798) add options to maven plugin (OpenAPITools#1845) fix unqiue name in handling forward slash (OpenAPITools#1839) better handle of oauth (OpenAPITools#1838) [C] Support for authentication methods (OpenAPITools#1628) better error message when parameter ref not defined (OpenAPITools#1837) Add links to articles about openapi generator Add a link to @watiko article Delete langs command (OpenAPITools#1836) ...
A-Joshi
pushed a commit
to ihsmarkitoss/openapi-generator
that referenced
this pull request
Feb 27, 2019
* added auth support in apiClient * added httperror response in detail * added apikey to apiClient create * remove unnecessary print statements * remove freeing of apiclient object from apiclient_free function * added auth params to apiClient_free function * free only received data and apiClient object to be freed by user
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.shand./bin/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\.master,. Default:3.4.x,4.0.xmaster.Description of the PR
Adding support for generating code related to authentication methods (basic, oauth and api-key).
Added error printing in case of the server is not available(curl perform failed).
Make apiClient object reusable(url, authentication are not freed and have to be freed manually) (dataReceived in apiclient will still be freed. As it is not necessay outside the API function).