Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JAVA][APACHE] Fix apache http client query parameters #14020

Conversation

sorin-florea
Copy link
Contributor

@sorin-florea sorin-florea commented Nov 15, 2022

Porting #11682 and #13656 to the apache client.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (6.3.0) (minor release - breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@sorin-florea sorin-florea changed the title Fix apache http client query parameters Fix apache http client query parameters [JAVA][APACHE Nov 15, 2022
@sorin-florea sorin-florea changed the title Fix apache http client query parameters [JAVA][APACHE JAVA][APACHE] Fix apache http client query parameters Nov 15, 2022
@sorin-florea sorin-florea marked this pull request as ready for review November 15, 2022 08:27
@sorin-florea sorin-florea changed the title JAVA][APACHE] Fix apache http client query parameters [JAVA][APACHE] Fix apache http client query parameters Nov 15, 2022
@sorin-florea
Copy link
Contributor Author

@wing328
Copy link
Member

wing328 commented Nov 23, 2022

LGTM. I'll file another PR with minor improvements and add some tests.

@wing328 wing328 merged commit d74cefb into OpenAPITools:master Nov 23, 2022
@wing328 wing328 added this to the 6.3.0 milestone Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants