-
-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tests for rust reqwest middleware client #13990
Conversation
This reverts commit 42d8ff4.
I'm kind of confused why these need to be added individually like this? |
- uses: actions/checkout@v3 | ||
- uses: actions-rs/toolchain@v1 | ||
with: | ||
toolchain: stable |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should consider setting an MSRV here, or ideally having a matrix of both MSRV and latest. Similar to:
https://github.com/actix/actix-web/blob/45b77c68195eb933231290a09e9f6a0cca56aad8/.github/workflows/ci.yml#L21-L23
And then if we only run clippy on the MSRV so we avoid the issues here:
#13907
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for sharing that. agreed with the matrix of both MSRV and the latest.
let's see if anyone has time to do it in a separate PR after merging this one.
Co-authored-by: Nathan Shaaban <[email protected]>
Add tests for rust reqwest middleware client
PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.For Windows users, please run the script in Git BASH.
master
(6.3.0) (minor release - breaking changes with fallbacks),7.0.x
(breaking changes without fallbacks)cc @frol (2017/07) @farcaller (2017/08) @richardwhiuk (2019/07) @paladinzh (2020/05) @jacob-pro (2022/10)