Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Go] Fix "allOf" inherited model properties by embedding parent models #12684

Closed

Conversation

DouglasDwyer
Copy link

This PR addresses issue #10219. The Go client generator does not include properties from allOf dependencies in generated models. This is solved by embedding the parent models into the generated Go structs, making all properties (including inherited ones) available on models. This behavior also more closely matches the Swagger API generator, which handles allOf cases like this by including all of the inherited properties (including parent properties) in the generated models.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (6.0.1) (patch release), 6.1.x (breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request. @antihax @grokify @kemokemo @jirikuncar @ph4r5h4d

@DouglasDwyer DouglasDwyer reopened this Jun 23, 2022
@DouglasDwyer DouglasDwyer changed the base branch from master to 6.1.x June 23, 2022 22:53
@wing328 wing328 changed the base branch from 6.1.x to master October 15, 2022 08:48
@lwj5
Copy link
Contributor

lwj5 commented Apr 14, 2023

Hi @DouglasDwyer, would you mind re-updating this PR, giving me permission to edit your branch on your behalf, or allowing me to open another PR with your code?

Let me know, so that we can get this moving

@DouglasDwyer
Copy link
Author

@lwj5 unfortunately, I don't have the ability to give you edit permissions on that branch. Sorry - just a matter of how the logistics worked out. However, you are more than welcome to fork the branch and open up your own PR! Once a new PR is up, I will close this one. Let me know if you have any questions :)

@wing328
Copy link
Member

wing328 commented Apr 15, 2023

please try to enable REFACTOR_ALLOF_WITH_PROPERTIES_ONLY in the openapi-normalizer and that should add back the missing properties

ref: https://github.com/OpenAPITools/openapi-generator/blob/master/docs/customization.md#openapi-normalizer

@wing328
Copy link
Member

wing328 commented Apr 15, 2023

closing this. will reopen if needed.

@wing328 wing328 closed this Apr 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants