Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

php-laravel, enum models, nullable and default values #12480

Merged
merged 5 commits into from
May 27, 2022

Conversation

wing328
Copy link
Member

@wing328 wing328 commented May 26, 2022

  • support for enum models & separating mustache templates for enums and generics
  • extract property 'type' and 'default value' from a #ref to an enum model
  • support for PascalCase naming convention for PHP generators
  • use a default value for known basic types when they are not nullable
  • use 'null' as default value for nullable types when they do not specify the default value
  • use defined constant path as enum default value when found

credits: @aghajani

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (6.0.1) (patch release), 6.1.x (breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

cc @jebentier (2017/07), @dkarlovi (2017/07), @mandrean (2017/08), @jfastnacht (2017/09), @ybelenko (2018/07), @renepardon (2018/12)

aghajani and others added 5 commits February 15, 2022 15:52
…nd generics

+ extract property 'type' and 'default value' from a #ref to an enum model
+ support for `PascalCase` naming convention for PHP generators
+ use a default value for known basic types when they are not nullable
+ use 'null' as default value for nullable types when they do not specify the default value
+ use defined constant path as enum default value when found
@wing328
Copy link
Member Author

wing328 commented May 27, 2022

Tested locally:

69 packages you are using are looking for funding.
Use the `composer fund` command to find out more!
[INFO] 
[INFO] --- exec-maven-plugin:1.2.1:exec (bundle-copy-config) @ LaravelPetstoreServerTests ---
[INFO] 
[INFO] --- exec-maven-plugin:1.2.1:exec (bundle-application-key-set) @ LaravelPetstoreServerTests ---
Application key set successfully.
[INFO] 
[INFO] --- exec-maven-plugin:1.2.1:exec (bundle-test) @ LaravelPetstoreServerTests ---
PHPUnit 8.5.26 #StandWithUkraine

..                                                                  2 / 2 (100%)

Time: 206 ms, Memory: 18.00 MB

OK (2 tests, 2 assertions)
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  29.349 s
[INFO] Finished at: 2022-05-27T11:06:04+08:00
[INFO] ------------------------------------------------------------------------

@wing328 wing328 merged commit 76eddeb into master May 27, 2022
@wing328 wing328 deleted the virta-ltd-feature/php-laravel-enums-and-nullable branch May 27, 2022 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants