Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[typescript-fetch] Removed functions that are unused when withoutRuntime is true. #12101

Merged
merged 2 commits into from
Apr 13, 2022
+4 −10
Merged

[typescript-fetch] Removed functions that are unused when withoutRuntime is true. #12101

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f64e215
[typescript-fetch] remove unused function when withoutRuntimeCheks op…
mkusaka Apr 9, 2022
a2dc7db
[typescript-fetch] update samples
mkusaka Apr 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions modules/openapi-generator/src/main/resources/typescript-fetch/runtime.mustache
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,10 +211,12 @@ export interface RequestOpts {
body?: HTTPBody;
}

{{^withoutRuntimeChecks}}
export function exists(json: any, key: string) {
const value = json[key];
return value !== null && value !== undefined;
}
{{/withoutRuntimeChecks}}

export function querystring(params: HTTPQuery, prefix: string = ''): string {
return Object.keys(params)
Expand All @@ -238,12 +240,14 @@ export function querystring(params: HTTPQuery, prefix: string = ''): string {
.join('&');
}

{{^withoutRuntimeChecks}}
export function mapValues(data: any, fn: (item: any) => any) {
return Object.keys(data).reduce(
(acc, key) => ({ ...acc, [key]: fn(data[key]) }),
{}
);
}
{{/withoutRuntimeChecks}}

export function canConsumeForm(consumes: Consume[]): boolean {
for (const consume of consumes) {
Expand Down
10 changes: 0 additions & 10 deletions samples/client/petstore/typescript-fetch/builds/without-runtime-checks/src/runtime.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,10 +222,6 @@ export interface RequestOpts {
body?: HTTPBody;
}

export function exists(json: any, key: string) {
const value = json[key];
return value !== null && value !== undefined;
}

export function querystring(params: HTTPQuery, prefix: string = ''): string {
return Object.keys(params)
Expand All @@ -249,12 +245,6 @@ export function querystring(params: HTTPQuery, prefix: string = ''): string {
.join('&');
}

export function mapValues(data: any, fn: (item: any) => any) {
return Object.keys(data).reduce(
(acc, key) => ({ ...acc, [key]: fn(data[key]) }),
{}
);
}

export function canConsumeForm(consumes: Consume[]): boolean {
for (const consume of consumes) {
Expand Down