Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

9904 Fix double quoting default values in Kotlin Spring #11627

Merged
merged 1 commit into from
Feb 25, 2022
Merged

9904 Fix double quoting default values in Kotlin Spring #11627

merged 1 commit into from
Feb 25, 2022

Conversation

bamapookie
Copy link
Contributor

@bamapookie bamapookie commented Feb 16, 2022

Fix for #9904.

Kotlin files with default values that are not enums were getting double quoted (defaultValue = ""default"") in API file generation. This fixes the issue for query parameters.

The first commit adds a method to the petstore sample that uses the code path demonstrating this bug. See the second commit for the invalid source generated. (kotlin-springboot)

CC: Kotlin committee members @jimschubert, @dr4ke616, @karismann, @Zomzog, @andrewemery, @4brunu, and @yutaka0m

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (5.3.0), 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

Fix should go into 5.4.0 branch as well.

@bamapookie
Copy link
Contributor Author

I'm unsure what to do here. There are tests failing for go and jaxrs, but I don't know why. I added a new endpoint to openapi-generator/src/test/resources/2_0/petstore.yaml, because that is the file that generated the samples, but the documentation in CONTRIBUTING.md says to update openapi-generator/src/test/resources/3_0/petstore-with-fake-endpoints-models-for-testing.yaml. Which one should I update?

@wing328
Copy link
Member

wing328 commented Feb 23, 2022

For the Go related error in CircleCI node 2, please ignore that for the time being.

@bamapookie
Copy link
Contributor Author

Rebased on current upstream master.

@wing328
Copy link
Member

wing328 commented Feb 23, 2022

cc @jimschubert (2017/09) ❤️, @dr4ke616 (2018/08) @karismann (2019/03) @Zomzog (2019/04) @andrewemery (2019/10) @4brunu (2019/11) @yutaka0m (2020/03)

@wing328
Copy link
Member

wing328 commented Feb 25, 2022

Tested locally to confirm the fix. Thanks for the PR.

I'll try to add some tests later to cover this.

@wing328 wing328 merged commit 258b605 into OpenAPITools:master Feb 25, 2022
@bamapookie bamapookie deleted the 9904_fix_double_quoting_default_values branch February 26, 2022 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants