Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Scala-Akka-Http] Fix deprecated ActorMaterializer since akka-http 2.6 #11048

Merged

Conversation

s-nel
Copy link
Contributor

@s-nel s-nel commented Dec 6, 2021

Fixes a deprecation issue in the Akka HTTP client generator for Scala. The ActorMaterializer type and constructor have been deprecated since Akka HTTP 2.6.0 and are throwing a warning.

ApiInvoker.scala:94:58
[E]      method apply in object ActorMaterializer is deprecated (since 2.6.0): Use the system wide materializer with stream attributes or configuration settings to change defaults
[E]      L94:   private implicit val materializer: ActorMaterializer = ActorMaterializer()
ApiInvoker.scala:94:38
[E]      class ActorMaterializer in package stream is deprecated (since 2.6.0): The Materializer now has all methods the ActorMaterializer used to have
[E]      L94:   private implicit val materializer: ActorMaterializer = ActorMaterializer()

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (5.3.0), 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

cc @clasnake @jimschubert @shijinkui @ramzimaalej @chameleon82 @Bouillie

@wing328 wing328 added Client: Scala Enhancement: Code Cleanup General refactoring, removal of deprecated things, commenting, etc. labels Dec 6, 2021
@wing328 wing328 added this to the 5.3.1 milestone Dec 6, 2021
@wing328
Copy link
Member

wing328 commented Dec 6, 2021

To close #11047

@wing328
Copy link
Member

wing328 commented Dec 6, 2021

@s-nel thanks for the PR. Please follow step 3 to update the samples so that the CI can verify the change: https://github.com/OpenAPITools/openapi-generator/runs/4432240440?check_suite_focus=true

@s-nel s-nel force-pushed the akka-http-deprecated-materializer branch from 2981ade to dab5515 Compare December 6, 2021 20:16
@s-nel
Copy link
Contributor Author

s-nel commented Dec 6, 2021

@s-nel thanks for the PR. Please follow step 3 to update the samples so that the CI can verify the change: https://github.com/OpenAPITools/openapi-generator/runs/4432240440?check_suite_focus=true

Ah thanks, I forgot to push them. They're pushed now

@wing328
Copy link
Member

wing328 commented Dec 17, 2021

Thanks for the PR, which looks good to me.

@wing328 wing328 merged commit 80d1eed into OpenAPITools:master Dec 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Client: Scala Enhancement: Code Cleanup General refactoring, removal of deprecated things, commenting, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants