Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[swift5] Refactor some codes #10937

Merged
merged 4 commits into from
Nov 23, 2021
Merged

Conversation

funzin
Copy link
Contributor

@funzin funzin commented Nov 23, 2021

Refactor some swift5 codes

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (5.3.0), 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@funzin
Copy link
Contributor Author

funzin commented Nov 23, 2021

@4brunu
Please review it when you have time.

Copy link
Contributor

@4brunu 4brunu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@funzin Hey, thanks for creating this PR.
It's a nice improvement.
Looks good to me 👍
Thanks

@wing328 wing328 added Client: Swift Enhancement: Code Cleanup General refactoring, removal of deprecated things, commenting, etc. labels Nov 23, 2021
@wing328 wing328 added this to the 5.3.1 milestone Nov 23, 2021
@wing328 wing328 merged commit faae00d into OpenAPITools:master Nov 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Client: Swift Enhancement: Code Cleanup General refactoring, removal of deprecated things, commenting, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants