Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JAVA]Add additional check for openapiDocketConfig in SpringCodegan.java #10853

Merged
merged 4 commits into from
Nov 20, 2021

Conversation

S2021Git
Copy link
Contributor

@S2021Git S2021Git commented Nov 13, 2021

Before the fix, OpenAPIDocumentationConfig.java can still be generated if swaggerDocketConfig is set to false
After the fix, OpenAPIDocumentationConfig.java will not be generated if the property is set to false

This is to fix #10287

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (5.3.0), 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@S2021Git S2021Git changed the title Add additional check for openapiDocketConfig in SpringCodegan.java [JAVA]Add additional check for openapiDocketConfig in SpringCodegan.java Nov 13, 2021
@wing328 wing328 merged commit 6848c22 into OpenAPITools:master Nov 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG][JAVA] swaggerDocketConfig not working as expected
2 participants