Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(drone): use parallel pipelines #10423

Merged
merged 1 commit into from
Sep 21, 2021

Conversation

PiDelport
Copy link
Contributor

@PiDelport PiDelport commented Sep 18, 2021

Docs: https://docs.drone.io/pipeline/configuration/#multiple-pipelines

This should reduce the Drone CI build time substantially: instead of testing all the languages sequentially, the build should only take as long as the language with the longest test time. (Currently, that's java11-test, which takes less than half the time of the sequential total.)

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (5.3.0), 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@PiDelport PiDelport force-pushed the ci-drone-parallel-pipelines branch from ddb48e9 to 738154a Compare September 20, 2021 08:40
@wing328
Copy link
Member

wing328 commented Sep 21, 2021

Thanks for the enhancement. Let's merge it and see how that goes

@wing328 wing328 merged commit 5c45465 into OpenAPITools:master Sep 21, 2021
@wing328 wing328 added this to the 5.3.0 milestone Sep 21, 2021
PiDelport added a commit to PiDelport/openapi-generator that referenced this pull request Sep 21, 2021
Drone requires unique pipeline names, which PR OpenAPITools#10423 (5c45465) missed.
@PiDelport
Copy link
Contributor Author

@wing328: Apologies, this caused a regression! Fixed in:

wing328 pushed a commit that referenced this pull request Sep 22, 2021
Drone requires unique pipeline names, which PR #10423 (5c45465) missed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants