Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG][JAVA] ApiException error code is private without getter #6830

Closed
6 tasks done
Xendar opened this issue Jul 1, 2020 · 3 comments · Fixed by #7150
Closed
6 tasks done

[BUG][JAVA] ApiException error code is private without getter #6830

Xendar opened this issue Jul 1, 2020 · 3 comments · Fixed by #7150
Labels
Issue: Bug

Comments

@Xendar
Copy link
Contributor

Xendar commented Jul 1, 2020 •
edited
Loading

Bug Report Checklist

  • Have you provided a full/minimal spec to reproduce the issue?
  • Have you validated the input using an OpenAPI validator (example)?
  • What's the version of OpenAPI Generator used?
  • Have you search for related issues/PRs?
  • What's the actual output vs expected output?
  • [Optional] Bounty to sponsor the fix (example)
Description

The ApiException.mustache template provides a useful exception with code and name, but unfortunately the code is private (well, that's good actually) but there is no getter to access it, so we cannot really use it...

openapi-generator version

4.3.1

OpenAPI declaration file content or url

https://github.com/OAI/OpenAPI-Specification/blob/master/examples/v3.0/petstore.yaml

Command line used for generation

java -jar openapi-generator-cli-4.3.1.jar generate -i https://raw.githubusercontent.com/OAI/OpenAPI-Specification/master/examples/v3.0/petstore.yaml -g jaxrs-resteasy -o gen

Steps to reproduce

Run the generator and open gen/java/org/openapitools/api/ApiException.java

Related issues/PRs

None found

Suggest a fix

Adding a basic getter should be enough
@wing328
Copy link
Member

wing328 commented Jul 2, 2020

Adding a basic getter should be enough

Your suggestion sounds good. I wonder if you can submit a PR with the proposed fix so that we can review it more easily.

@Xendar
Copy link
Contributor Author

Xendar commented Jul 2, 2020

Adding a basic getter should be enough

Your suggestion sounds good. I wonder if you can submit a PR with the proposed fix so that we can review it more easily.

I'll try :)

@Xendar Xendar mentioned this issue Aug 6, 2020
Merged
6 tasks
@Xendar
Copy link
Contributor Author

Xendar commented Aug 6, 2020

Pull Request #7150 created

Xendar added a commit to Xendar/openapi-generator that referenced this issue Aug 7, 2020
@Xendar
Issue OpenAPITools#6830: Java server - Add getter to ApiException tem…
5a184e4 
…plates
wing328 pushed a commit that referenced this issue Aug 9, 2020
@Xendar
Issue #6830: Java server - Add getter to ApiException templates (#7150)
930c622
jimschubert added a commit that referenced this issue Aug 12, 2020
@jimschubert
Merge branch 'master' into path-handling
4c9b64f 
* master: (27 commits)
  [WIP][python-exp] Force camelization of imports (#7186)
  Fixes #6942: Added ability to prepend a basePath to typescript-redux-query generators (#6943)
  [Typescript] Import path is invalid in windows. (#7175)
  Fix JaxRS Spec generator additional model types (#7180)
  [python{,-experimental}] Obey floating point timeouts provided to RESTClientObject.request(...) (#7154)
  [C#] Switch the spec to OAS v3 from v2 (#7176)
  [Javascript] Fixing the handling of non primitive types in paramToString (#7171) (#7172)
  [typescript-node] Fix invalid type when using node@10 and ES5 (#7133)
  Minor fix to github workflow badge
  [gradle] Enabling up-to-date checks and gradle caching for openapigenerator tasks (#6716)
  feat(csharp-netcore): Adding response headers to the ApiException (#7169)
  [ci] Verify supported JDK versions on master push (#7085)
  Issue #6830: Java server - Add getter to ApiException templates (#7150)
  update kotlin samples
  [Kotlin] Make ApiClient in jvm-retrofit2 be able to use own OkHttpClient (#6999)
  Sttp - wrap query params (#6884)
  Add a link to https://medium.com/@everisBrasil blog post (#7160)
  [C#][netcore] fix regular expression when it contains double quotes (#7147)
  remove duplicated cancellationToken in comment (#7148)
  update samples
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Issue: Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Java][jaxrs] Add getter to ApiException templates Xendar/openapi-generator
2 participants
@wing328 @Xendar