DefaultCodegen: Inheritance (allOf) parent not working when it is not at first position

[janssen92]

Description

The inheritance is not working, the inherited attributes are not included in the generated files. (E.g. GetProofingConfigDto misses all ProofingConfigDto attriubtes)

Additionally, the generator warns about Objects, which SwaggerCodegen did not:
[main] WARN o.o.codegen.DefaultCodegen - Unknown type found in the schema: object

openapi-generator version

3.0.2

OpenAPI declaration file content or url

https://github.com/janssen92/swagger-feedback-service-api/blob/testOpenApiGenerator/swagger-feedback.json
https://github.com/janssen92/swagger-feedback-service-api/blob/testOpenApiGenerator/swagger-feedback-conf.json

Command line used for generation

java -jar ~/git/openapi-generator/modules/openapi-generator-cli/target/openapi-generator-cli.jar generate -i swagger-feedback.json -g spring -o ~/testOpenApiGen --library spring-boot --config swagger-feedback-conf.json
But also same result with less parameters:
java -jar ~/git/openapi-generator/modules/openapi-generator-cli/target/openapi-generator-cli.jar generate -i swagger-feedback.json -g spring -o ~/testOpenApiGen

Steps to reproduce

• Checkout file(s)
• Generate Code

[janssen92]

Tested it with v3 as well as v2

[janssen92]

It works just fine with Swagger Codegen 2.3.1

[jmini]

Might be a duplicate of #192

[jmini]

I did not investigate this issue in detail, but I think it is the same than #192 and therefore it might be fixed with PR #358.

[jmini]

Can you check the latest 3.0.3-SNAPSHOT version?

[janssen92]

I can not find any 3.0.3-SNAPSHOT, but I just pulled and build current Master. There is still no inherited Attributes in some classes. (In others the 'extend' ist used just fine). I think the reason is: If you use 'allOf' and then a $ref as the first array element it works just fine. But if the $ref is a later array Element (e.g. the last one) the 'extend' isn't generated. This wasn't an Issue with Swagger-Gen so far.

[jmini]

Our SNAPSHOT builds are pushed to the sonatype snapshot repository:
https://oss.sonatype.org/content/repositories/snapshots

For example the CLI jar is the newest jar in this folder:
https://oss.sonatype.org/content/repositories/snapshots/org/openapitools/openapi-generator-cli/3.0.3-SNAPSHOT/

Or you can just use Maven to download it for you.

---

Anyway thanks for having tested this...

You are telling that this works:

definitions:
  SomeObject:
    type: object
    allOf:
      - $ref: "#/definitions/OtherObject"
      - type: object
        required:
          - bla
        properties:
          bla:
            type: string
  OtherObject:
    type: object
    properties:
      p1:
        type: string
      p2:
        type: string

And this one does not work:

definitions:
  SomeObject:
    type: object
    allOf:
      - type: object
        required:
          - bla
        properties:
          bla:
            type: string
      - $ref: "#/definitions/OtherObject"
  OtherObject:
    type: object
    properties:
      p1:
        type: string
      p2:
        type: string

If this is your issue, I can have a look at it.

[janssen92]

Ah thanks for the links, I will check it out.

Yes, your example is correct, didn't notice that pattern when I created the issue, but now that I know it, it seems to be correct for all problems

[jmini]

Well with 3.0.2 both cases are broken. 3.0.3-SNAPSHOT solves the case with $ref at first position. The remaining work to solve this issue is to handle cases where $ref is not at first position.

[jmini]

The way getParentName(..) is implemented makes the case clear:

openapi-generator/modules/openapi-generator/src/main/java/org/openapitools/codegen/DefaultCodegen.java

Lines 3949 to 3959 in d3b1721

	protected String getParentName(ComposedSchema composedSchema, Map<String, Schema> allSchemas) {
	if (composedSchema.getAllOf() != null && !composedSchema.getAllOf().isEmpty()) {
	Schema schema = composedSchema.getAllOf().get(0);
	String ref = schema.get$ref();
	if (StringUtils.isBlank(ref)) {
	return null;
	}
	return ModelUtils.getSimpleRef(ref);
	}
	return null;
	}

In a allOf construct, if the parent is not at first position it is ignored...

In my opinion we could improve this by taking the first $ref we find in the allOf-List...

@OpenAPITools/generator-core-team what do you think?

[Shockolate]

I'm getting a bunch of these errors as well when trying to generate typescript code.
Tried with 3.2.3, 3.3.x (most recent as of posting SNAPSHOT), and 4.x.x (most recent as of posting SNAPSHOT).

[main] WARN  o.o.codegen.DefaultCodegen - Unknown type found in the schema: object
[main] WARN  o.o.codegen.DefaultCodegen - More than one inline schema specified in allOf:. Only the first one is recognized. All others are ignored.

[ackintosh]

#340 (comment)

In my opinion we could improve this by taking the first $ref we find in the allOf-List...

I agree with that. I'll file a PR to improve so. 😉