Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rSharp_create_domain should return a flag #117

Closed
PavelBal opened this issue Mar 15, 2024 · 6 comments · Fixed by #136
Closed

rSharp_create_domain should return a flag #117

PavelBal opened this issue Mar 15, 2024 · 6 comments · Fixed by #136
Assignees

Comments

@PavelBal
Copy link
Member

Loading assembly might throw an unhandled exception, which crashes R.

@rwmcintosh
Copy link
Member

What branch are you working in?
Seems like that should be part of the issue #53 which has been worked on in #112

@rwmcintosh
Copy link
Member

But not yet merged

@PavelBal
Copy link
Member Author

Yes working on that branch.

@rwmcintosh
Copy link
Member

Ok, when you can reproduce let's see. I expect the title will have to change somehow because we are catching exceptions and returning flags from C# to C++ and then C++ is returning a meaningful SEXP based on the flag.

@rwmcintosh rwmcintosh assigned rwmcintosh and unassigned rwmcintosh Mar 15, 2024
@PavelBal PavelBal changed the title rSharp_load_assembly should try-catch rSharp_load_assembly should return a flag Mar 15, 2024
@PavelBal PavelBal changed the title rSharp_load_assembly should return a flag rSharp_create_domain should return a flag Mar 15, 2024
@PavelBal
Copy link
Member Author

  • Throw an error if dotnetlib_path is NULL

@rwmcintosh
Copy link
Member

This came up through a series of unfortunate events, but anyway, if a user does not call rsharp_create_domain, but calls other methods, the exception would happen and we should not crash R process in that event.

@PavelBal PavelBal moved this to Ready in RSharp V1 Apr 9, 2024
@rwmcintosh rwmcintosh linked a pull request Apr 12, 2024 that will close this issue
@rwmcintosh rwmcintosh moved this from Ready to In progress in RSharp V1 Apr 12, 2024
@rwmcintosh rwmcintosh moved this from In progress to In review in RSharp V1 Apr 12, 2024
@rwmcintosh rwmcintosh self-assigned this Apr 12, 2024
PavelBal added a commit that referenced this issue Apr 16, 2024
@github-project-automation github-project-automation bot moved this from In review to Done in RSharp V1 Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants