Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redirect URL? #71

Closed
m-mohr opened this issue Sep 30, 2021 · 3 comments
Closed

Redirect URL? #71

m-mohr opened this issue Sep 30, 2021 · 3 comments
Labels
Milestone

Comments

@m-mohr
Copy link
Member

m-mohr commented Sep 30, 2021

#' file that will contain information about the 'client_id' and 'secret'. The redirect URL requested from the provider is 'http://localhost:1410/'.

Is this correct? I thought it should be http://localhost:1410/callback

Edit: It seems it is, at least httr only mentions port 1410 and no path. But I'm pretty sure previously we had used callback as a path in some client IDs...

@m-mohr
Copy link
Member Author

m-mohr commented Sep 30, 2021

We should probably also document that the "Authorization Code Grant" (correct?) is used...

@m-mohr m-mohr added this to the CRAN milestone Sep 30, 2021
@m-mohr m-mohr added the high label Sep 30, 2021
@flahn
Copy link
Member

flahn commented Oct 4, 2021

I had implemented the callback handling manually a while back, before switching to the httr solution. There I started a plumber webserver and was waiting for the respective callback from the OIDC provider, so that I didn't have to copy the access token manually.

But as recently httr is using localhost:1410 as default endpoint for the callback. So the documentation is correct in this regard. I will change the documentation as you suggested and try to link to the httr documentation for further information.

flahn added a commit that referenced this issue Oct 4, 2021
@flahn
Copy link
Member

flahn commented Oct 7, 2021

I did some more code digging and found it finally in httr::oauth_callback. The URL is http://localhost:1410/

@m-mohr m-mohr closed this as completed Oct 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants