Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenEOClient$connect ignores host set by OpenEOClient$new #100

Closed
benjaminschwetz opened this issue Dec 1, 2021 · 4 comments · Fixed by #106
Closed

OpenEOClient$connect ignores host set by OpenEOClient$new #100

benjaminschwetz opened this issue Dec 1, 2021 · 4 comments · Fixed by #106
Assignees
Milestone

Comments

@benjaminschwetz
Copy link

Hi,

I just noticed that the connect method returns an error when I set the url via new. I tested with openeo 1.1.0

library(openeo)
#> 
#> Attaching package: 'openeo'
#> The following objects are masked from 'package:base':
#> 
#>     capabilities, debug
x = OpenEOClient$new(host = "example.foo")
x$connect()
#> Note: Host-URL is missing

Created on 2021-12-01 by the reprex package (v2.0.1)

@flahn
Copy link
Member

flahn commented Dec 2, 2021

Thanks for spotting this. The parameter url in $connect() was mandatory and did not take into account that it could have been set upon initialization. So, now you will receive a message, that the url example.foo cannot be resolved, what it is kind of to be expected.

@flahn flahn added this to the v1.2.0 milestone Jan 14, 2022
@m-mohr
Copy link
Member

m-mohr commented Jan 14, 2022

Doesn't work for me yet, I'm getting:

> library(openeo)
> x = OpenEOClient$new(host = "https://openeo.cloud")
> x$getHost()
[1] "https://openeo.cloud"
> x$connect()
Argument "url" fehlt (ohne Standardwert)

I'm on R 4.0.2

@m-mohr
Copy link
Member

m-mohr commented Jan 14, 2022

Weird, after updating to the latest commit I get:

> library(openeo)
> x = OpenEOClient$new(host = "https://openeo.cloud")
> x$getHost()
[1] "https://openeo.cloud"
> x$connect()
host must be a single element of type 'character'

@m-mohr
Copy link
Member

m-mohr commented Jan 18, 2022

Fix for the issue above in PR #100

@m-mohr m-mohr removed their assignment Jan 18, 2022
@m-mohr m-mohr linked a pull request Jan 18, 2022 that will close this issue
@m-mohr m-mohr closed this as completed Jan 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants