Skip to content

Commit

Permalink
fixed warnings in describe_collection (#145))
Browse files Browse the repository at this point in the history
fixed warning messages shown on `describe_collection()` using an object of class `Collection` from `list_collection()` [#145](#145)
  • Loading branch information
flahn committed Feb 2, 2024
1 parent a956f43 commit c8d8505
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
3 changes: 2 additions & 1 deletion NEWS.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,8 @@
* CollectionId argument now checks if a string pattern is available
* OutputFormat argument checks the "FileFormat" class separately to avoid warnings
* fixed automated selection of a suitable OIDC provider on login [#142](https://github.com/Open-EO/openeo-r-client/issues/142), where the first OIDC in the list was chosen. Now it checks for the first OIDC provider with `default_clients` defined.
* fixed tan issue where it was not possible to connect to an openEO back-end with a dedicated link (also for reconnect in the connection contract)
* fixed an issue where it was not possible to connect to an openEO back-end with a dedicated link (also for reconnect in the connection contract)
* fixed warning messages shown on `describe_collection()` using an object of class `Collection` from `list_collection()` [#145](https://github.com/Open-EO/openeo-r-client/issues/145)
* .create_sample_bbox interpretes now correctly a serialized extent object
* .find_process_by_name is no longer giving a false message when a process is passed to it

Expand Down
2 changes: 1 addition & 1 deletion R/collections.R
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ describe_collection = function(collection = NA, con=NULL) {
return(NULL)
})

missing_collection = missing(collection) || length(collection) == 0 || is.na(collection) || nchar(collection) == 0
missing_collection = !(length(collection) > 0 && any(!is.na(collection)) && !(is.character(collection) && length(collection) == 1 && nchar(collection) > 0))

if (missing_collection) {
message("No or invalid collection id(s)")
Expand Down

0 comments on commit c8d8505

Please sign in to comment.