Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schema overrides for geometry in read_vector/aggregate_spatial #136

Closed
soxofaan opened this issue Aug 29, 2022 · 2 comments
Closed

Schema overrides for geometry in read_vector/aggregate_spatial #136

soxofaan opened this issue Aug 29, 2022 · 2 comments
Assignees

Comments

@soxofaan
Copy link
Member

Moving the technical discussion from https://discuss.eodc.eu/t/server-error-413-request-entity-too-large/451/ to here:

@m-mohr : In aggregate_spatial you need to allow vector cubes and strings as input geometries
@soxofaan : We follow the official aggregate_spatial spec, so that depends on Open-EO/openeo-processes#323 and related vector-cube (loading) api/processes
@m-mohr : Yes, but you don’t implement the official specification, but you actually implement more than the official spec. So you’d need to add two additional schemas. One for strings and one for vector-cubes. Once we have an understanding of vector-cubes that will also land in the official spec, but we are not there yet (while VITO somewhat is).

To be clear: the geometry as URL (string) is a pure client-side feature in the python client: a read_vector node is automatically added. A string geometry is not supported by the VITO back-end directly.

Also, back-end side "vector-cube support" is a bit of a stretch, we only support GeoJSON-style feature collections (so GeoJSON inlined directly as process arg, or from a file/URL through additional read_vector process). So that makes me wonder if it wouldn't be better to change the output of read_vector to {"type": "object", "subtype": "geojson"}.

@m-mohr
Copy link
Member

m-mohr commented Aug 29, 2022

Ah, I did not realize the string is a client-side thing. Having that in mind, it sounds like a good idea to change the return type to geojson, indeed.

soxofaan added a commit that referenced this issue Oct 5, 2022
Eventually, `read_vector` or its official replacement will return vector cubes, but for now, "geojson object" is a more honest description of the return type
@soxofaan
Copy link
Member Author

soxofaan commented Oct 5, 2022

With 5ad0c5e there is not much to be done here anymore I think,
the remaining vector cube will be done elsewhere

@soxofaan soxofaan closed this as completed Oct 5, 2022
@soxofaan soxofaan self-assigned this Oct 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants