Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

apply_dimension: Clarification of behavior #357 #400

Merged
merged 2 commits into from
Feb 28, 2023
Merged

apply_dimension: Clarification of behavior #357 #400

merged 2 commits into from
Feb 28, 2023

Conversation

m-mohr
Copy link
Member

@m-mohr m-mohr commented Jan 31, 2023

Fixes #357

@m-mohr m-mohr added this to the 1.3.0 milestone Jan 31, 2023
@m-mohr m-mohr linked an issue Jan 31, 2023 that may be closed by this pull request
apply_dimension: Clarification of behaviour #357
Closed
@m-mohr m-mohr modified the milestones: 1.3.0, 2.0.0 Feb 1, 2023
LukeWeidenwalker
LukeWeidenwalker approved these changes Feb 28, 2023
View reviewed changes
Copy link
Contributor

@LukeWeidenwalker LukeWeidenwalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@m-mohr m-mohr merged commit d9e80d4 into draft Feb 28, 2023
@m-mohr m-mohr deleted the issue-357 branch February 28, 2023 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LukeWeidenwalker LukeWeidenwalker LukeWeidenwalker approved these changes

@dthiex dthiex dthiex approved these changes

@soxofaan soxofaan Awaiting requested review from soxofaan

@Ardweaden Ardweaden Awaiting requested review from Ardweaden

Assignees
No one assigned
Labels
documentation must-have
Projects
None yet
Milestone
2.0.0-rc.2
Development

Successfully merging this pull request may close these issues.

apply_dimension: Clarification of behaviour
3 participants
@m-mohr @LukeWeidenwalker @dthiex