Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Load/Save ML model #300 #304

Merged
merged 5 commits into from
Mar 9, 2022
Merged

Load/Save ML model #300 #304

merged 5 commits into from
Mar 9, 2022

Conversation

m-mohr
Copy link
Member

@m-mohr m-mohr commented Nov 16, 2021

Draft for issue #300.

@m-mohr m-mohr changed the base branch from master to draft November 16, 2021 15:49
@m-mohr m-mohr added this to the 1.2.0 milestone Nov 16, 2021
@m-mohr m-mohr linked an issue Nov 16, 2021 that may be closed by this pull request
load/save_model for ML models #300
Closed
@m-mohr
Copy link
Member Author

m-mohr commented Nov 17, 2021 •
edited
Loading

In the dev telco, the idea came up to integrate loading and/or saving into the ML processes. If they are tightly coupled and you can't do more things with ML models, we may actually want to consider this to make the user experience better. In this case, these processes would be merged with the ML processes. I don't feel like I have enough experience to decide so would appreciate your thoughts.

@m-mohr m-mohr mentioned this pull request Nov 18, 2021
Merged
@m-mohr
Copy link
Member Author

m-mohr commented Nov 24, 2021

Meeting conclusion: Have load/save specifically as process to seperate concerns and be more flexible in the future. Also, makes the processes a bit simpler.

@m-mohr m-mohr self-assigned this Nov 26, 2021
@m-mohr m-mohr modified the milestones: 1.2.0, 1.3.0 Nov 29, 2021
@m-mohr m-mohr requested review from soxofaan and edzer December 13, 2021 11:48
@m-mohr m-mohr marked this pull request as ready for review December 13, 2021 11:48
@m-mohr m-mohr added the ML label Dec 13, 2021
@m-mohr m-mohr linked an issue Dec 21, 2021 that may be closed by this pull request
Better ML/AI integration? #211
Closed
@m-mohr m-mohr added the help wanted Extra attention is needed label Feb 24, 2022
soxofaan
soxofaan reviewed Mar 8, 2022
View reviewed changes
Copy link
Member

@soxofaan soxofaan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some minor notes

proposals/load_ml_model.json Show resolved Hide resolved
proposals/save_ml_model.json Show resolved Hide resolved
@m-mohr m-mohr mentioned this pull request Mar 9, 2022
Closed
@m-mohr
Copy link
Member Author

m-mohr commented Mar 9, 2022 •
edited
Loading

Merging, please open a separate issue or PR to discuss further changes. Please report additional requirements for the ml-model extension here: https://github.com/stac-extensions/ml-model/issues

@m-mohr m-mohr merged commit bdbd6f6 into draft Mar 9, 2022
@m-mohr m-mohr deleted the issue-300 branch March 9, 2022 15:16
@m-mohr m-mohr modified the milestones: 1.3.0, 2.0.0 Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soxofaan soxofaan soxofaan left review comments

@jdries jdries Awaiting requested review from jdries

@mattia6690 mattia6690 Awaiting requested review from mattia6690

@SerRichard SerRichard Awaiting requested review from SerRichard

@edzer edzer Awaiting requested review from edzer

Assignees

@m-mohr m-mohr

Labels
help wanted Extra attention is needed ML new process platform
Projects
None yet
Milestone
2.0.0-rc.2
Development

Successfully merging this pull request may close these issues.

load/save_model for ML models Better ML/AI integration?
2 participants
@m-mohr @soxofaan