Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make aggregate_polygon and filter_polygon more general #131

Merged
merged 11 commits into from
Jan 30, 2020
Merged

Conversation

m-mohr
Copy link
Member

@m-mohr m-mohr commented Jan 20, 2020

Make aggregate_polygon and filter_polygon more general (broaden it for points and line strings). (Is there a use case for mask_polygon, too?)

Tackles issues #62 and #37. Based on PR #107 from @kempenep.

@m-mohr m-mohr added the help wanted Extra attention is needed label Jan 20, 2020
@m-mohr m-mohr added this to the v1.0-rc1 milestone Jan 20, 2020
@m-mohr
Copy link
Member Author

m-mohr commented Jan 27, 2020

Hey @GreatEmerald! Could you please check this PR asap so that it is sure it suits your use-case? I'll need a response this week, I'll release on Friday at latest.

@GreatEmerald
Copy link
Member

OK, I'll try to look into this tomorrow.

Copy link
Member

@GreatEmerald GreatEmerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still a few minor changes are needed, but overall looks good. See specific comments.

@m-mohr m-mohr merged commit bb0bd28 into draft Jan 30, 2020
@m-mohr m-mohr deleted the issue-62 branch January 30, 2020 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants