Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aggregate_temporal: Parameter labels is optional #122

Merged
merged 1 commit into from
Jan 15, 2020
Merged

aggregate_temporal: Parameter labels is optional #122

merged 1 commit into from
Jan 15, 2020

Conversation

m-mohr
Copy link
Member

@m-mohr m-mohr commented Jan 15, 2020

Adresses a suggestion from @jdries in #19: The labels parameter in aggregate_temporal is now optional. By default the start times of the intervals are used. In case of conflicts, labels is still required.

@m-mohr m-mohr added this to the v1.0-rc1 milestone Jan 15, 2020
@m-mohr m-mohr requested review from soxofaan, jdries and mkadunc January 15, 2020 17:01
Copy link
Contributor

@jdries jdries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@m-mohr m-mohr merged commit 23af6b7 into draft Jan 15, 2020
@m-mohr m-mohr deleted the issue-19 branch January 15, 2020 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants