Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

load_collection and polygon, return only data inside the polygon? #256

Closed
clausmichele opened this issue May 28, 2021 · 3 comments
Closed
Labels
documentation help wanted Extra attention is needed
Milestone

Comments

@clausmichele
Copy link
Member

I am wondering if by API definition, when providing a polygon in load_collection, we need to return the masked data or just the data contained the minimum bbox of the polygon.

@clausmichele clausmichele changed the title load_collection and polygon, reurn only data inside te polygon? load_collection and polygon, reurn only data inside the polygon? May 28, 2021
@clausmichele clausmichele changed the title load_collection and polygon, reurn only data inside the polygon? load_collection and polygon, return only data inside the polygon? May 28, 2021
@m-mohr
Copy link
Member

m-mohr commented May 28, 2021

The process says:

The process puts a pixel into the data cube if the point at the pixel center intersects with the bounding box or any of the polygons (as defined in the Simple Features standard by the OGC).

I'm understanding that as follows (and it was meant this way): The data cube has the extent of the box of the polygons. All pixels that do not intersect with the polygon(s) contain no-data / null values. All other values that intersect with the polygon(s) contain data from the given collection.

Would you understand it differently from the description? If yes, how can we improve the descriptions?

@m-mohr m-mohr added documentation help wanted Extra attention is needed labels May 28, 2021
@m-mohr m-mohr added this to the 1.1.0 milestone May 28, 2021
@clausmichele
Copy link
Member Author

No it's fine, it is also as I understand it. But maybe we can clarify that outside the polygon we have to set data to no-data/null, which is not clear (I was wrongly setting them to zero).

m-mohr added a commit that referenced this issue May 28, 2021
m-mohr added a commit that referenced this issue May 28, 2021
@m-mohr
Copy link
Member

m-mohr commented May 28, 2021

Okay, thanks, I added some clarifications to load_collection: 5826803

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants