Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resample_spatial missing dimensions causing a crash #249

Merged
merged 8 commits into from
May 24, 2024
Merged

resample_spatial missing dimensions causing a crash #249

merged 8 commits into from
May 24, 2024

Conversation

jzvolensky
Copy link
Contributor

If dimensions are missing the resample_spatial crashes as it is out of range.

Fix + updated test is on the way

Zvolenský Juraj and others added 5 commits April 5, 2024 09:35
… N dimensional transpose support to keep the data.openeo functionality
…l. Updated test_resample to test different combinations (x,y,bands),(x,y,t),(x,y)
@jzvolensky
Copy link
Contributor Author

Latest commit should fix this issue, @clausmichele @ValentinaHutter can you please review the test as I am not 100% sure it works the way I want it to. It should basically test the different combinations (x,y,bands) , (x,y,t), (x,y) with the parametrization. If that is not the case I can review it again. Thank you!

@clausmichele
Copy link
Member

Hi @jzvolensky, I've reviewed the code and it is fine for me. Please change the status of the PR from draft to ready.

@jzvolensky jzvolensky marked this pull request as ready for review May 13, 2024 12:24
@clausmichele
Copy link
Member

@jzvolensky tests are not passing anymore. From a quick check it seems for that for Python 3.9 the issue seems related to the odc package. For python 3.10 and 3.11 the error seems to be in how you are calling the reduce_dimension (check the reduce_dimension tests to see how to call it).

@ValentinaHutter
Copy link
Collaborator

We have been looking into the python3.9 issue this week and decided to remove python3.9 from the supported versions, Please pull from the latest version. :)

@ValentinaHutter ValentinaHutter merged commit efd214f into Open-EO:main May 24, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants