Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make actinia process names openeo-conform #90

Merged
merged 1 commit into from
May 6, 2021
Merged

Conversation

metzm
Copy link
Collaborator

@metzm metzm commented May 6, 2021

No description provided.

@metzm metzm requested review from neteler and mmacata May 6, 2021 08:07
@mmacata
Copy link
Collaborator

mmacata commented May 6, 2021

I don't see a difference?

>>> pm = dict()
>>> pm['id'] = "%s_%s" % ('r.slope.aspect', 'slope')
>>> process = pm["id"].replace('.', '_')
>>> process
'r_slope_aspect_slope'

>>> pm = dict()
>>> pm['id'] = 'r.slope.aspect'
>>> process = "%s_%s" % (pm['id'].replace('.', '_'), 'slope')
>>> process
'r_slope_aspect_slope'

@mmacata
Copy link
Collaborator

mmacata commented May 6, 2021

Ah sorry - overlooked that pm['id'] is also overwritten. Fine for me - but is it ok that we then have the same id multiple times?

@metzm
Copy link
Collaborator Author

metzm commented May 6, 2021

Fine for me - but is it ok that we then have the same id multiple times?

Yes because the id is the original name of the GRASS module which we need to construct the actinia pg. No problem if multiple openeo processes are wrappers for the same GRASS module.

@metzm metzm merged commit d8811be into master May 6, 2021
@metzm metzm deleted the actinia_process_names branch May 6, 2021 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants