Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

openeo GRASS driver: continue linting #82

Merged
merged 3 commits into from
Mar 31, 2021
Merged

openeo GRASS driver: continue linting #82

merged 3 commits into from
Mar 31, 2021

Conversation

metzm
Copy link
Collaborator

@metzm metzm commented Mar 30, 2021

  • fix F821

@metzm metzm requested a review from mmacata March 30, 2021 13:11
@metzm
Copy link
Collaborator Author

metzm commented Mar 30, 2021

In tests/test_process_graph_validation.py are some deactivated tests, but the corresponding python code has not been commented out or removed, causing F821 errors. Any suggestion what to do with these tests?

@mmacata
Copy link
Collaborator

mmacata commented Mar 30, 2021

In tests/test_process_graph_validation.py are some deactivated tests, but the corresponding python code has not been commented out or removed, causing F821 errors. Any suggestion what to do with these tests?

Is it deprecated code for an older API version? They seem to succeed if some deprecated code is not available. So for me it seems to be a solution while upgrading to the new api version and can be removed now.

@metzm
Copy link
Collaborator Author

metzm commented Mar 30, 2021

In tests/test_process_graph_validation.py are some deactivated tests, but the corresponding python code has not been commented out or removed, causing F821 errors. Any suggestion what to do with these tests?

[...] for me it seems to be a solution while upgrading to the new api version and can be removed now.

OK, removed.
The only errors left are now E501 line too long

@mmacata mmacata self-requested a review March 31, 2021 14:09
mmacata
mmacata approved these changes Mar 31, 2021
View reviewed changes
Copy link
Collaborator

@mmacata mmacata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@metzm metzm merged commit 02e896b into master Mar 31, 2021
@metzm metzm deleted the linting_contd branch March 31, 2021 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmacata mmacata mmacata approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@metzm @mmacata