Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify that UTF-8 is the default charset #462 #466

Merged
merged 2 commits into from
Nov 7, 2022
Merged

Clarify that UTF-8 is the default charset #462 #466

merged 2 commits into from
Nov 7, 2022

Conversation

m-mohr
Copy link
Member

@m-mohr m-mohr commented Nov 2, 2022

Fixes #462

  • Explicitly mention the use of HTTP content negotiation
  • Clarify that the default charset is UTF-8 #462

@m-mohr m-mohr added this to the 1.2.0 milestone Nov 2, 2022
@m-mohr m-mohr linked an issue Nov 2, 2022 that may be closed by this pull request
Clarify character encoding #462
Closed
SerRichard
SerRichard reviewed Nov 3, 2022
View reviewed changes
SerRichard
SerRichard reviewed Nov 3, 2022
View reviewed changes
Copy link

@SerRichard SerRichard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one comment on line 35, unsure what the last sentence really means, and also just highlighting a typo.

@m-mohr m-mohr merged commit 77a0cb3 into draft Nov 7, 2022
@m-mohr m-mohr deleted the charset branch November 7, 2022 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SerRichard SerRichard SerRichard left review comments

@dthiex dthiex dthiex approved these changes

@soxofaan soxofaan Awaiting requested review from soxofaan

@flahn flahn Awaiting requested review from flahn

@clausmichele clausmichele Awaiting requested review from clausmichele

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.2.0
Development

Successfully merging this pull request may close these issues.

Clarify character encoding
3 participants
@m-mohr @dthiex @SerRichard