-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Link to process examples instead of inlining them. #285 #286
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general the changes are fine with me, but had some questions.
In R I don't really use it, because it is hard to make good use of it on a command line level. However, when visualizing it in a browser, I will use the openEO JS commons.
I am using it at the QGIS Plugin, but its not really important and no big deal to adapt this. So its fine with me. As far as I know, the Python client is not using them, but I am not up to date there. |
@bgoesswe What are you using it for in the QGIS plug in? |
There is a Tab with backend information, where you can explore the processes of the backend and there I added examples (if given) to an Infobox text. |
In python client or VITO backend we don't use the examples programatically (only as inspiration for implementation/testing). So fine for me |
@bgoesswe Could you link me to the corresponsing code file? |
Oh, I think it is currently removed from the Tab, but I still read the metadata from the processes endpoint here. |
@bgoesswe That part of the code is still valid though as there's still the "argument-only" examples, which are like 90+% of the current examples. But if you need to re-implement it anyway, then we are fine :-) |
see #285
I think none of the clients (except some of my JS tooling) relies on this / implements this anyway, right? @flahn @bgoesswe @jdries
For back-ends this is not really a breaking change.
Corresponding process changes are in Open-EO/openeo-processes#151