Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link to process examples instead of inlining them. #285 #286

Merged
merged 2 commits into from
May 26, 2020
Merged

Conversation

m-mohr
Copy link
Member

@m-mohr m-mohr commented May 25, 2020

see #285

I think none of the clients (except some of my JS tooling) relies on this / implements this anyway, right? @flahn @bgoesswe @jdries

For back-ends this is not really a breaking change.

Corresponding process changes are in Open-EO/openeo-processes#151

@m-mohr m-mohr added the process discovery and profile discovery label May 25, 2020
@m-mohr m-mohr added this to the v1.0.0-final milestone May 25, 2020
@m-mohr m-mohr requested a review from soxofaan May 25, 2020 13:28
@m-mohr m-mohr linked an issue May 25, 2020 that may be closed by this pull request
@m-mohr m-mohr requested review from bgoesswe, flahn and jdries May 25, 2020 13:32
@m-mohr m-mohr mentioned this pull request May 25, 2020
m-mohr added a commit that referenced this pull request May 25, 2020
m-mohr added a commit that referenced this pull request May 25, 2020
Copy link
Member

@flahn flahn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general the changes are fine with me, but had some questions.

In R I don't really use it, because it is hard to make good use of it on a command line level. However, when visualizing it in a browser, I will use the openEO JS commons.

@bgoesswe
Copy link
Member

I am using it at the QGIS Plugin, but its not really important and no big deal to adapt this. So its fine with me. As far as I know, the Python client is not using them, but I am not up to date there.

@m-mohr
Copy link
Member Author

m-mohr commented May 26, 2020

@bgoesswe What are you using it for in the QGIS plug in?

@bgoesswe
Copy link
Member

There is a Tab with backend information, where you can explore the processes of the backend and there I added examples (if given) to an Infobox text.

@soxofaan
Copy link
Member

In python client or VITO backend we don't use the examples programatically (only as inspiration for implementation/testing). So fine for me

@m-mohr
Copy link
Member Author

m-mohr commented May 26, 2020

@bgoesswe Could you link me to the corresponsing code file?

@bgoesswe
Copy link
Member

Oh, I think it is currently removed from the Tab, but I still read the metadata from the processes endpoint here.

@m-mohr
Copy link
Member Author

m-mohr commented May 26, 2020

@bgoesswe That part of the code is still valid though as there's still the "argument-only" examples, which are like 90+% of the current examples. But if you need to re-implement it anyway, then we are fine :-)

@m-mohr m-mohr merged commit 1483968 into draft May 26, 2020
@m-mohr m-mohr deleted the issue-285 branch May 26, 2020 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
process discovery and profile discovery
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Process Examples incomplete
4 participants