-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Case insensitive handling of runtime names #409
Comments
Unfortunately, I don't think we can enforce this in openEO API v1. It seems we did not consider case-insensitivity for UDF runtimes and now we can't easily add it without breaking things. It was different for the other entities (e.g. file formats) where we only improved the wording. This would also need a change in openeo-processes (e.g. run_udf). |
For v1 we could already add a recommendation for case insensitive handling, which is not breaking and still allows alignment before v2 |
Hmm, I think I don't really agree with that due to the reasons below: As for billing plans and web services, the API allows CI and also defines the places where the names can be used in CI manner. For file formats (and as requested here in UDF runtimes), we can just give a general direction in the API and say that CI is allowed (or recommended). The API itself doesn't use these names in a CI manner. This is then (from a user POV) only really implemented in the processes (save_result allows CI/run_udf doesn't mention CI right now, i.e. is CS), but there it would read weird (and break things) in the user-facing documentation if it would say "UDF runtime name is allowed to be given in CI manner". So the only place where we could recommend this are the API and the implementation notes for processes. User could not be informed about it so I'm not sure how useful this recommendation would be and it could break interoperability (in v1) a bit by having process graphs that run on one back-end and not on another one. |
I was mainly thinking about a CI recommendation or requirement for back-end implementers. I don't think it's very useful for a regular end user, indeed.
We already have an interoperability problem: if one backend calls its Python runtime Another solution is adding a guideline for the runtime names ("lower case only" or "must be Camel Case", ...) or explicitly list some examples for popular runtimes ( |
Indeed. We should probably aim for a recommended naming, maybe best proposed by the UDF runtime implementation. I've expanded the OpenAPI with a general recommendation for now:
Which would result in Leaving this open for consideration in API v2. |
openeo-api/openapi.yaml
Lines 1627 to 1635 in f303d65
Like #371 we should enforce handling UDF runtime names in case insensitive manner, I think
The text was updated successfully, but these errors were encountered: