Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid name in favor of id and title #130

Closed
m-mohr opened this issue Oct 6, 2018 · 2 comments
Closed

Avoid name in favor of id and title #130

m-mohr opened this issue Oct 6, 2018 · 2 comments
Assignees
Milestone

Comments

@m-mohr
Copy link
Member

m-mohr commented Oct 6, 2018

In the specification it is defined that each process and collection has a name. This name is expected to be a unique identifier. I'd propose to change this to an id due to the following reasons:

  • id and title are unambiguous, name is not. Throughout software industry name is used for both titles and identifiers. Just by changing name to id the documentation would be much clearer what is expected there.
  • Consistency. name is used for processes and datasets, all other use id. As WFS/STAC will change to id, we should also apply this ton the processes. It would also make the conection to process_id in the process graph more clear.

Related issues: opengeospatial/ogcapi-features#171 + radiantearth/stac-spec#262

@m-mohr m-mohr added this to the v0.4 milestone Oct 6, 2018
@m-mohr m-mohr self-assigned this Oct 6, 2018
@m-mohr
Copy link
Member Author

m-mohr commented Nov 7, 2018

For consistency, we should align with data discovery and process discovery and replace "service_id", "process_graph_id", "job_id" etc in their entities responses with "id".

m-mohr added a commit that referenced this issue Dec 6, 2018
…s and the `job_id` of jobs has changed to `id` in responses (#130). The `status` property of jobs is now required.
@m-mohr
Copy link
Member Author

m-mohr commented Dec 6, 2018

Implemented where unambiguous.

@m-mohr m-mohr closed this as completed Dec 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant