Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CORE: Update gpSP (now GBA default, has netplay) #1721

Merged
merged 6 commits into from
Dec 22, 2024

Conversation

Aemiii91
Copy link
Member

@Aemiii91 Aemiii91 commented Dec 22, 2024

Changes

  • Updated gpSP to libretro/gpsp@36061ca
  • Made it the default GBA emulator
  • Added mGBA save check and transfer prompt
  • Enabled netplay (only Wireless adapter is supported - see compatible games)

Save check logic (updated in: 6cd13b4)

  • Does no gpSP state or save exist?
    • Does an mGBA save exist?
      • Prompt user: transfer save or keep using mGBA?
        • Transfer: Copy the mGBA srm save to gpSP
        • Keep mGBA: Set mGBA as game core
    • Does an mGBA state exist?
      • Set mGBA as game core
  • None of the above: Use gpSP

@Aemiii91 Aemiii91 added the enhancement New or improved feature label Dec 22, 2024
@Aemiii91 Aemiii91 self-assigned this Dec 22, 2024
@Aemiii91 Aemiii91 merged commit 27cc13d into main Dec 22, 2024
2 checks passed
@Aemiii91 Aemiii91 deleted the upd-gpsp-default-netplay branch December 22, 2024 22:29
@SkyWalker541
Copy link

Hey, I am testing out the 4.4 beta. I don't see a folder for the gpSP core in "saves". Where should I place saves from the mGBA folder?

I did see the prompt to transfer from mGBA to gpSP, but it doesn't show my in game saves. Is there something I should refresh, delete, or transfer?

Maybe changing the file extensions?

Thanks Aemiii91

@Aemiii91
Copy link
Member Author

@SkyWalker541 hi thanks for testing this!

The saves go in Saves/CurrentProfile/saves/gpSP (just create the folder if it doesn't exist)

At this point we're unsure whether saves can even be transferred. All I know is that gpSP now uses srm files (just like mGBA), but resent test results would indicate that these aren't transferable 😕

We might need to remove the transfer option.

@jlnr
Copy link

jlnr commented Dec 23, 2024

I've manually switched from mGBA to gpSP a while ago, and only had to change the file extension for it to work.

@Aemiii91
Copy link
Member Author

@jlnr are you saying that old gpSP saves (.sav) work in the new gpSP if you rename the extension to .srm? Maybe we should add a migration script that does this for you 🤔

@jlnr
Copy link

jlnr commented Dec 23, 2024

Ah sorry, this was on 4.3.1 (mGBA to old gpSP). Will see what happens when I install 4.4.0.

@Grayjks
Copy link
Contributor

Grayjks commented Dec 23, 2024

hello, i have test netplay in gpsp, can connect but not working in battle or trade, here is video:
https://www.youtube.com/watch?v=I5GmCkVRt-4

@SkyWalker541
Copy link

OK, I got saves transferred over.

I found a Unix Executable File called "gpSP" in Save/CurrentProfile/saves. Once I deleted that file, I was able to create a "gpSP" folder, and copy and paste the .srm save files over from the "mGBA" folder.

Everything seems to be working now.

I did test both .srm and .sav formats. The .srm files work in "gpSP", and .sav does not.

I am not sure what the Unix Executable File was, or if it was created during the Onion migration process for the saves. I do know that I needed to delete it to create the "gpSP" save folder, as they had the same file name.

I think you are correct, that a migration script will work. Possibly deleting the Unix Executable File if present, creating a "gpSP" folder and copying the saves over should work.

Hope this makes sense and helps you.

Thanks again Aemiii91

@Aemiii91 Aemiii91 changed the title Update gpSP core (new GBA default, has netplay) CORE: Update gpSP (now GBA default, has netplay) Dec 24, 2024
@jr9011
Copy link

jr9011 commented Jan 7, 2025

hello, i have test netplay in gpsp, can connect but not working in battle or trade, here is video: https://www.youtube.com/watch?v=I5GmCkVRt-4

Does that mean netplay for trade is yet to be working?

@Grayjks
Copy link
Contributor

Grayjks commented Jan 7, 2025 via email

@jr9011
Copy link

jr9011 commented Jan 16, 2025

Is the trade thing fixed?

@Grayjks
Copy link
Contributor

Grayjks commented Jan 16, 2025

Is the trade thing fixed?

Now trade and battle work, i have test again in pokemon emerald :D Here video: enjoy
https://youtu.be/T3vjz7OresE

@jr9011
Copy link

jr9011 commented Jan 16, 2025

Thanks grayjks. Can only trade between same same game? Can't do fire red and leaf green for example? I keep getting communication errors

@Grayjks
Copy link
Contributor

Grayjks commented Jan 17, 2025

Thanks grayjks. Can only trade between same same game? Can't do fire red and leaf green for example? I keep getting communication errors

Just only same game

@Grayjks
Copy link
Contributor

Grayjks commented Jan 17, 2025

Haha that's disappointing. Thought we can trade across different games. Now how to change a saved fire red game to leaf green?

you need to google it or get in the discord to ask, i dont know haha

@jr9011
Copy link

jr9011 commented Jan 20, 2025

@Aemiii91 hi good sir, would there be a cross-game trade option soon?

@Aemiii91
Copy link
Member Author

@jr9011 I don't think anyone is working on that, no

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New or improved feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants