Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: broken link in advance guides #1489

Merged
merged 5 commits into from
May 9, 2024
Merged

Fix: broken link in advance guides #1489

merged 5 commits into from
May 9, 2024

Conversation

PhyrexTechs
Copy link
Contributor

Updated Big Zoom link to my server hosting the file here: https://files.phyrextechs.com/share/BSKak5jy

Not sure if this is frowned upon here and it would be better to host somewhere else. Please let me know.

Sorry for making another PR I'm new and was unsure of the proper protocol and messed up my last branch.

Please direct me to any information on the proper ways to help out as I don't want to create more work for others.

Thanks.

Updated Big Zoom link to my server hosting the file.
@Aemiii91
Copy link
Member

Aemiii91 commented Mar 8, 2024

How about just adding the file to the files directory (in this repo)?

@PhyrexTechs
Copy link
Contributor Author

Wow. Yeah, I'm not sure what I was thinking.

I added another commit that adds the zip file to the files directory and linked to it in the advanced guide.

Let me know if that is the correct files directory or if there was someone else you had in mind.

@Aemiii91
Copy link
Member

Perfect. Though I'm unsure if the relative link will work, I'll have to test.

@PhyrexTechs
Copy link
Contributor Author

Changed the link to an absolute path. Used the raw link so it should download while staying on the same page.

@Aemiii91 Aemiii91 enabled auto-merge May 9, 2024 11:11
@Aemiii91 Aemiii91 added this pull request to the merge queue May 9, 2024
Merged via the queue into OnionUI:main with commit 8cc4d36 May 9, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants