Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NewCclCommMgr on runtime #10617

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

NewCclCommMgr on runtime #10617

wants to merge 1 commit into from
+6 −2

Conversation

ShawnXuan
Copy link
Collaborator

问题描述：
import oneflow时会创建一些全局对象，其中下面段落创建了NewCclCommMgr对象。
https://github.com/Oneflow-Inc/oneflow/blob/master/oneflow/core/job/env_global_objects_scope.cpp#L200-L208

不过当使用非CUDA设备时，无法创建NewCclCommMgr对象，在runtime阶段带来一些问题。

这里的改动，就是在runtime阶段也尝试创建NewCclCommMgr对象。

注：NewCclCommMgr对象的创建，依赖RegisterEagerCclCommMgrType

没有解决的问题：在runtime之前，NewCclCommMgr对象仅仅用于InsertNcclLogicalOpPass，我觉得，并不是必须的，或许就可以把NewCclCommMgr对象的创建放到后面，不过涉及的范围比较大，怕有其他副作用。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Flowingsun007 Flowingsun007 Flowingsun007 approved these changes

@mosout mosout Awaiting requested review from mosout

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ShawnXuan @Flowingsun007